Calling the failure block of send tags for bad input #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we would log a warning and return on bad input for the sendTags method. Now we will also call the failure block with an error object with information on what went wrong. This fixes #951
emawby
force-pushed
the
fix/failure_block_in_send_tags
branch
from
e86eba0
to
a898d60
Compare
Jeasmine
approved these changes
Jun 24, 2021
|
|
||
| // Make sure the tags were not sent. | ||
| [NSObjectOverrider runPendingSelectors]; | ||
| [UnitTestCommonMethods runBackgroundThreads]; | ||
| [NSObjectOverrider runPendingSelectors]; | ||
|
|
||
|
|
There was a problem hiding this comment.
Can we remove this extra \n?
emawby
force-pushed
the
fix/failure_block_in_send_tags
branch
from
a898d60
to
d2bd2e4
Compare
jkasten2
approved these changes
Jun 25, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Jeasmine)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would log a warning and return on bad input for the sendTags method. Now we will also call the failure block with an error object with information on what went wrong. This fixes #951
This change is