Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling the failure block of send tags for bad input #952

Merged
merged 2 commits into from
Jun 25, 2021
Merged

Calling the failure block of send tags for bad input #952

merged 2 commits into from
Jun 25, 2021

Commits on Jun 23, 2021

  1. Calling the failure block of send tags for bad input 

    Previously we would log a warning and return on bad input for the sendTags method. Now we will also call the failure block with an error object with information on what went wrong. This fixes #951
    @emawby
    emawby committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    b72b3f2 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2021

  1. make sure failure block is called in send tags bad input unit test

    @emawby
    emawby committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    d2bd2e4 View commit details
    Browse the repository at this point in the history