Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/calling nil failure block and OneSignal.h set to public #961

Merged
merged 2 commits into from
Jul 21, 2021
Merged

Fix/calling nil failure block and OneSignal.h set to public #961

merged 2 commits into from
Jul 21, 2021

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Jul 21, 2021 •
edited by jwilm
Loading

This PR fixes 2 issues.

  1. We were not checking that the failureBlock of sendTags was non-nil before trying to call it.
  2. The OneSignal.h header file was set to project instead of Public which prevents building.

This change is Reviewable

jkasten2
jkasten2 approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @Jeasmine and @nan-li)

@emawby emawby merged commit a241b6a into main Jul 21, 2021
@emawby emawby deleted the fix/calling_nil_failureBlock branch July 21, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkasten2 jkasten2 jkasten2 approved these changes

@Jeasmine Jeasmine Awaiting requested review from Jeasmine

@nan-li nan-li Awaiting requested review from nan-li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emawby @jkasten2