Fix missing push notification capability error detection #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* It is not reliable to use a string check on an error message to map to a specific OneSignal error code. * Second there is only one reason you would get a 3000 error code, the push notification capability is not enabled. - The 3000 "other" error that was being reported was never a thing. - This "other" 3000 error happens when the device is not set to English. - Also recently (iOS 13 or 14) the English error message changed. * This means we will no longer see the confusing "Other Apns 3000 Error" message on the OneSignal dashboard and will now see the correct "Missing Push Capability".
* Per the last commit we no longer will be using "other 3000" and instead this will always be ERROR_PUSH_CAPABLILITY_DISABLED instead. * Keeping the define but post-fixing with "_UNUSED_RESERVED" - This is so we don't reuse this notification_types value later and keep this around so someone can git-blame to find this reasoning.
* Updated it with new instructions based what was observed in Xcode 12.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Replace the "Other Apns 3000 Error" error with the correct "Missing Push Capability" error.
Details
See commit-by-commit for more details.
Testing
Tested on Xcode 12.4 and on an iPhone running iOS 14.4.1.
This change is