Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing push notification capability error detection #962

Merged
merged 3 commits into from
Jul 22, 2021
Merged

Fix missing push notification capability error detection #962

merged 3 commits into from
Jul 22, 2021

Commits on Jul 22, 2021

  1. rm push registration string 3000 error parsing 

    * It is not reliable to use a string check on an error message to map
to a specific OneSignal error code.
* Second there is only one reason you would get a 3000 error code,
the push notification capability is not enabled.
  - The 3000 "other" error that was being reported was never a thing.
  - This "other" 3000 error happens when the device is not set to
  English.
  - Also recently (iOS 13 or 14) the English error message changed.
* This means we will no longer see the confusing "Other Apns 3000 Error"
  message on the OneSignal dashboard and will now see the correct
  "Missing Push Capability".
    @jkasten2
    jkasten2 committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    9aac81b View commit details
    Browse the repository at this point in the history

  2. Mark ERROR_PUSH_OTHER_3000 as unused 

    * Per the last commit we no longer will be using "other 3000"
and instead this will always be ERROR_PUSH_CAPABLILITY_DISABLED instead.
* Keeping the define but post-fixing with "_UNUSED_RESERVED"
  - This is so we don't reuse this notification_types value later and
  keep this around so someone can git-blame to find this reasoning.
    @jkasten2
    jkasten2 committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    4b7d046 View commit details
    Browse the repository at this point in the history

  3. Updated missing push notif capability error msg 

    * Updated it with new instructions based what was observed in Xcode 12.4
    @jkasten2
    jkasten2 committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    8119ee9 View commit details
    Browse the repository at this point in the history