Don't wait for push prompt to register user

[emawby]

Previously we would call registerUserAfterDelay if the user has not completed the push prompt or they don't have provisional auth. We want to register right away so that we can get IAMs for the session (which might include a push prompt IAM).

I believe this was intended to be an optimization to wait for an answer to the push prompt if the prompt is currently being display but that was not the behavior, and I don't think we need to try to achieve that optimization.

---

This change is 

[jkasten2]

Changes look good to me. In the future make sure to mix unrelated changes in the same PR. Especially in the same commit.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Jeasmine and @nan-li)

[jkasten2]

make sure not to mix*

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Jeasmine and @nan-li)

[jkasten2]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @emawby, @Jeasmine, and @nan-li)

---

iOS_SDK/OneSignalSDK/Source/OneSignal.m, line 1634 at r1 (raw file):

    self.currentSubscriptionState.pushToken = deviceToken;

    [self.osNotificationSettings getNotificationPermissionState:^(OSPermissionState *status) {

We are no longer using status so we don't need to call getNotificationPermissionState here.

[jkasten2]

One scenario I am not sure what will happen is if app project has "background modes" off for notifications. In this scenario we don't get an APNs response since it won't give us a token. I had a similar WIP PR to this one where it was an open question to come back too:
https://github.com/OneSignal/OneSignal-iOS-SDK/pull/891/files#diff-1188e625278a26833ef333f891da137dfbf384cde4f6c5f97ba8298e4eda5afaR772-R774

However we should investigate if this change will cause the player to never be created. If so we need to address it in this PR.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @emawby, @Jeasmine, and @nan-li)

[jkasten2]

Ignore the "background modes" off comment for this PR. Since the logic change is in updateDeviceToken this PR could not possibly change this. Something however we can look into later as a follow up.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @emawby, @Jeasmine, and @nan-li)

[emawby]

Reviewable status: 5 of 7 files reviewed, 1 unresolved discussion (waiting on @Jeasmine, @jkasten2, and @nan-li)

---

iOS_SDK/OneSignalSDK/Source/OneSignal.m, line 1634 at r1 (raw file):

Previously, jkasten2 (Josh Kasten) wrote…

We are no longer using status so we don't need to call getNotificationPermissionState here.

Done.

[jkasten2]

Reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Jeasmine and @nan-li)