Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logoutEmail() should probably return a promise #53

Closed
statico opened this issue Nov 9, 2021 · 1 comment · Fixed by #55
Closed

logoutEmail() should probably return a promise #53

statico opened this issue Nov 9, 2021 · 1 comment · Fixed by #55
Labels
Bug Something isn't working

Comments

@statico
Copy link

statico commented Nov 9, 2021

Right now it returns void, but clearly there's a network request happening. Chrome is showing me an uncaught exception when there's an error with the call. It would be nice to be able to catch this in my own code.

CleanShot 2021-11-09 at 13 56 22

@rgomezp
Copy link
Contributor

rgomezp commented Nov 9, 2021

Howdy,
Thanks for reporting. You are right, this should return a promise.

Thanks for your patience while we resolve.

@rgomezp rgomezp added the Bug Something isn't working label Nov 9, 2021
This was referenced Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants