AddAndReadVector::operator[]

Oneflow-Inc · Jun 13, 2022 · 1b0df76 · 1b0df76
1 parent a061c50
commit 1b0df76
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/oneflow/core/common/add_and_read_vector.h b/oneflow/core/common/add_and_read_vector.h
@@ -31,7 +31,7 @@ class AddAndReadVector {
   AddAndReadVector() : size_(0) {}
   ~AddAndReadVector() = default;
 
-  using value_type = T;
+  using value_type = const T;
   using size_type = size_t;
 
   // not thread safe.
@@ -46,10 +46,7 @@ class AddAndReadVector {
     return granularity2vector_[gran].data()[index - start];
   }
 
-  // lock free.
-  T& at(size_t index) {
-    CHECK_GE(index, 0);
-    CHECK_LT(index, size_);
+  const T& operator[](size_t index) const {
     int gran = GetGranularity(index);
     int start = (1 << gran) - 1;
     return granularity2vector_[gran].data()[index - start];

diff --git a/oneflow/core/common/container_util.h b/oneflow/core/common/container_util.h
@@ -57,7 +57,7 @@ Maybe<typename VecT::value_type&> VectorAt(VecT& vec, typename VecT::size_type i
   static_assert(!std::is_same<typename VecT::value_type, bool>::value,
                 "VectorAt(vector<bool>&, size_t) is not supported.");
   CHECK_LT_OR_RETURN(index, vec.size());
-  return vec.at(index);
+  return vec[index];
 }
 
 template<>