Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stack backward #7363

Merged
merged 15 commits into from
Jan 26, 2022
Merged

Fix stack backward #7363

merged 15 commits into from
Jan 26, 2022

Conversation

simonJJJ
Copy link
Contributor

No description provided.

simonJJJ added 13 commits October 4, 2021 22:51
@simonJJJ
fix typo
38b69b3
@simonJJJ
Merge branch 'master' of https://github.com/Oneflow-Inc/oneflow
8ee6465
@simonJJJ
Merge branch 'master' of https://github.com/Oneflow-Inc/oneflow
a5af37b
@simonJJJ
Merge branch 'master' of https://github.com/Oneflow-Inc/oneflow
da3502e
@simonJJJ
Merge branch 'master' of https://github.com/Oneflow-Inc/oneflow
2681ad3
@simonJJJ
Merge branch 'master' of https://github.com/Oneflow-Inc/oneflow
bf9ec14
@simonJJJ
Merge branch 'master' of https://github.com/Oneflow-Inc/oneflow
70bb1e9
@simonJJJ
Merge branch 'master' of https://github.com/Oneflow-Inc/oneflow
2b53b9a
@simonJJJ
Merge branch 'master' of https://github.com/Oneflow-Inc/oneflow
fbf6daa
@simonJJJ
Merge branch 'master' of https://github.com/Oneflow-Inc/oneflow
6d9d0f9
@simonJJJ
Merge branch 'master' of https://github.com/Oneflow-Inc/oneflow
de7975e
@simonJJJ
Merge branch 'master' of https://github.com/Oneflow-Inc/oneflow
0885fd9
@simonJJJ
fix stack backward
b3911a9
@simonJJJ simonJJJ requested a review from MARD1NO January 25, 2022 07:07
@simonJJJ simonJJJ requested a review from hjchen2 as a code owner January 25, 2022 07:07
@github-actions
Copy link
Contributor

Static analysis with clang failed. PR label automerge has been removed

@github-actions
Copy link
Contributor

CI failed when running job: cuda-module. PR label automerge has been removed

@simonJJJ simonJJJ requested review from oneflow-ci-bot and removed request for oneflow-ci-bot January 26, 2022 04:45
@oneflow-ci-bot oneflow-ci-bot removed their request for review January 26, 2022 05:21
@oneflow-ci-bot oneflow-ci-bot self-requested a review January 26, 2022 05:22
@github-actions
Copy link
Contributor

Speed stats: 
GPU Name: GeForce GTX 1080 

OneFlow resnet50 time: 136.7ms (= 13674.6ms / 100, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 139.9ms (= 13988.2ms / 100, input_shape=[16, 3, 224, 224])
✔️ Relative speed: 1.02 (= 139.9ms / 136.7ms)

OneFlow resnet50 time: 78.7ms (= 7865.6ms / 100, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 84.0ms (= 8398.0ms / 100, input_shape=[8, 3, 224, 224])
✔️ Relative speed: 1.07 (= 84.0ms / 78.7ms)

OneFlow resnet50 time: 52.2ms (= 10449.0ms / 200, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 53.5ms (= 10703.9ms / 200, input_shape=[4, 3, 224, 224])
✔️ Relative speed: 1.02 (= 53.5ms / 52.2ms)

OneFlow resnet50 time: 43.1ms (= 8622.4ms / 200, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 44.7ms (= 8943.4ms / 200, input_shape=[2, 3, 224, 224])
✔️ Relative speed: 1.04 (= 44.7ms / 43.1ms)

OneFlow resnet50 time: 40.5ms (= 8106.4ms / 200, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 40.8ms (= 8151.5ms / 200, input_shape=[1, 3, 224, 224])
✔️ Relative speed: 1.01 (= 40.8ms / 40.5ms)

OneFlow resnet50 time: 148.8ms (= 14885.0ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 161.2ms (= 16119.3ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.08 (= 161.2ms / 148.8ms)

OneFlow resnet50 time: 89.8ms (= 8980.6ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 101.9ms (= 10194.8ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.14 (= 101.9ms / 89.8ms)

OneFlow resnet50 time: 63.9ms (= 12782.2ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 72.5ms (= 14491.1ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.13 (= 72.5ms / 63.9ms)

OneFlow resnet50 time: 59.4ms (= 11880.2ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 61.0ms (= 12205.5ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.03 (= 61.0ms / 59.4ms)

OneFlow resnet50 time: 53.9ms (= 10780.2ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 58.7ms (= 11737.9ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.09 (= 58.7ms / 53.9ms)

@oneflow-ci-bot oneflow-ci-bot removed their request for review January 26, 2022 06:46
@oneflow-ci-bot oneflow-ci-bot merged commit 093056a into master Jan 26, 2022
@oneflow-ci-bot oneflow-ci-bot deleted the fix_stack_backward branch January 26, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MARD1NO MARD1NO MARD1NO approved these changes

@BBuf BBuf BBuf approved these changes

@Flowingsun007 Flowingsun007 Flowingsun007 approved these changes

@hjchen2 hjchen2 Awaiting requested review from hjchen2 hjchen2 is a code owner

Assignees
No one assigned
Labels
automerge bug eager op
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@simonJJJ @Flowingsun007 @BBuf @MARD1NO @oneflow-ci-bot