[IMP] mail_quoted_reply: Sanitize HTML body before quoting #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grindtildeath
force-pushed
the
17-mig-mail_quoted_reply
branch
from
ed48a0c to
601f9fb
Compare
As we are adding HTML from external messages into the mail composer HTML widget, we do not control what is in there and it could break the webclient or making it unresponsive depending on its content. Sanitizing the body of the quoted message might not solve all the issues, but it at least provides a hook for extra processing.
grindtildeath
force-pushed
the
17-mig-mail_quoted_reply
branch
from
601f9fb to
20f6417
Compare
ajaniszewska-dev
approved these changes
Nov 8, 2024
henrybackman
approved these changes
Nov 12, 2024
TDu
approved these changes
Nov 18, 2024
Abranes
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are adding HTML from external messages into the mail composer HTML widget, we do not control what is in there and it could break the webclient or making it unresponsive depending on its content.
Sanitizing the body of the quoted message might not solve all the issues, but it at least provides a hook for extra processing.