Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name of the geometries dimension #479

Closed
m-mohr opened this issue Jan 30, 2023 · 5 comments
Closed

Name of the geometries dimension #479

m-mohr opened this issue Jan 30, 2023 · 5 comments
Assignees
Milestone

Comments

@m-mohr
Copy link
Member

m-mohr commented Jan 30, 2023

The name for the vector dimension is now "geometries" (plural) in accordance with "bands", okay?

I don't think that changing to plural "geometries" is really necessary. Apart from "bands", all dimension types and names are/look singular: "spatial", "temporal", "x", "y", "other".

As another data point here: geopandas uses singular "geometry" as column type and name in data frames, e.g. see https://geopandas.org/en/stable/docs/reference/api/geopandas.GeoDataFrame.html#geopandas.GeoDataFrame

Originally posted by @soxofaan in #441 (comment)

@m-mohr
Copy link
Member Author

m-mohr commented Jan 30, 2023

I don't think that changing to plural "geometries" is really necessary.

Are you saying

       * `geometries` for dimensions of type `geometries`

should change to

      * `geometry` for dimensions of type `geometries`

?

@m-mohr
Copy link
Member Author

m-mohr commented Jan 30, 2023

I guess so.

If I understand correctly, the dimension type has already been settled on plural "geometries" in merged PR stac-extensions/datacube#10
so in this PR #441 there is only room to change the dimension name to singular "geometry", which would indeed not look very consistent in the recommendation

* name `geometry` for dimensions of type `geometries`

Sidenote: I noticed that @aljacob made related comment at Open-EO/openeo-processes#382 (review)

Originally posted by @soxofaan in #441 (comment)

@m-mohr m-mohr added this to the 2.0.0 milestone Jan 30, 2023
@m-mohr m-mohr self-assigned this Jan 30, 2023
@m-mohr
Copy link
Member Author

m-mohr commented Jan 30, 2023

@aljacob wrote in Open-EO/openeo-processes#382 (review) :

looks all good to me. My only concern would also be about the plural of geometries and bands, it would be cleaner to have both in singular, but it is nothing that is a big issue after all, at least these two are consistant then, as I guess it would be quite the effort for everyone to go from bands to band as well.

Indeed, bands is settled on the plural as we use it as such since the beginning. "geometries" seems well aligned - x,y,t are all defined in a way that they don't have a specific singular/plural version.

@m-mohr
Copy link
Member Author

m-mohr commented Mar 10, 2023

Voted to be "geometry"

@m-mohr
Copy link
Member Author

m-mohr commented Mar 10, 2023

Updated in commit 6da0195

@m-mohr m-mohr closed this as completed Mar 10, 2023
soxofaan added a commit to soxofaan/openeo.org that referenced this issue Aug 8, 2023
Type of geometry dimension is "geometry"

also see Open-EO/openeo-api#479
soxofaan added a commit to Open-EO/openeo-python-driver that referenced this issue Aug 8, 2023
soxofaan added a commit to Open-EO/openeo-python-driver that referenced this issue Aug 8, 2023
soxofaan added a commit to Open-EO/openeo-python-driver that referenced this issue Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant