From f2c07399ae0482640d1c1d9d5cfdfc001b7b1d81 Mon Sep 17 00:00:00 2001 From: Stefaan Lippens Date: Thu, 16 May 2024 13:36:19 +0200 Subject: [PATCH] Add todo notes on hardcoded VITO references Open-EO/openeo-python-driver#275 --- openeogeotrellis/async_task.py | 1 + openeogeotrellis/job_tracker_v2.py | 1 + openeogeotrellis/vault.py | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/openeogeotrellis/async_task.py b/openeogeotrellis/async_task.py index c0d44e1ed..3c6255986 100644 --- a/openeogeotrellis/async_task.py +++ b/openeogeotrellis/async_task.py @@ -158,6 +158,7 @@ def main(): help='Classpath used to launch the Java Gateway') parser.add_argument("--py4j-maximum-heap-size", default="1G", help='Maximum heap size for the Java Gateway JVM') + # TODO: eliminate hardcoded (VITO) defaults? Open-EO/openeo-python-driver#275 parser.add_argument("--principal", default="openeo@VGT.VITO.BE", help="Principal to be used to login to KDC") parser.add_argument("--keytab", default="openeo-deploy/mep/openeo.keytab", help="Path to the file that contains the keytab for the principal") diff --git a/openeogeotrellis/job_tracker_v2.py b/openeogeotrellis/job_tracker_v2.py index 81e57a181..ccb9ff5f3 100644 --- a/openeogeotrellis/job_tracker_v2.py +++ b/openeogeotrellis/job_tracker_v2.py @@ -682,6 +682,7 @@ def parse_cli_args(self, args: Optional[List[str]] = None) -> argparse.Namespace ) parser.add_argument( "--principal", + # TODO: eliminate hardcoded (VITO) defaults? Open-EO/openeo-python-driver#275 default="openeo@VGT.VITO.BE", help="Principal to be used to login to KDC", ) diff --git a/openeogeotrellis/vault.py b/openeogeotrellis/vault.py index adebeee6e..2e0adc16b 100644 --- a/openeogeotrellis/vault.py +++ b/openeogeotrellis/vault.py @@ -58,7 +58,7 @@ def login_jwt(self, access_token: str) -> str: @retry(exceptions=VaultLoginError, tries=4, delay=2, backoff=4, logger=_log) def login_kerberos( self, - # TODO: eliminate hardcoded defaults? + # TODO: eliminate hardcoded (VITO) defaults? Open-EO/openeo-python-driver#275 principal: str = "openeo@VGT.VITO.BE", keytab: str = "/opt/openeo.keytab", ) -> str: