Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aggregate_spatial: Statistics for more than one dimension? #126

Closed
m-mohr opened this issue Jan 16, 2020 · 6 comments · Fixed by #382
Closed

aggregate_spatial: Statistics for more than one dimension? #126

m-mohr opened this issue Jan 16, 2020 · 6 comments · Fixed by #382
Labels
breaking help wanted Extra attention is needed vector
Milestone

Comments

@m-mohr
Copy link
Member

m-mohr commented Jan 16, 2020

@mkadunc wrote in #123 (comment) regarding aggregate_polygon:

Why are we limiting this to one remaining dimension - e.g. why not get statistics over space for each (time,band) combination?

@m-mohr m-mohr added the help wanted Extra attention is needed label Jan 16, 2020
@m-mohr m-mohr added this to the v1.0-rc1 milestone Jan 16, 2020
@m-mohr
Copy link
Member Author

m-mohr commented Jan 17, 2020

Postponing to 1.0-final if there's no veto...

@m-mohr m-mohr modified the milestones: v1.0-rc1, v1.0 Jan 17, 2020
@m-mohr m-mohr modified the milestones: v1.0-final, future May 28, 2020
@m-mohr
Copy link
Member Author

m-mohr commented May 28, 2020

Hey @jdries , you were talking about aggregate_polygon today and it seems you are invested most into this process. What do you think about this? Ever stumbled across a need for this with your use cases?

@jdries
Copy link
Contributor

jdries commented Jun 9, 2020

Yes, we actually do retain the band dimension as well, so you can get a 'multiband' aggregated time series. This is maybe not compliant with the current spec, strictly speaking?

@m-mohr m-mohr changed the title aggregate_polygon: Statistics for more than one dimension? aggregate_spatial: Statistics for more than one dimension? Jun 9, 2020
@m-mohr
Copy link
Member Author

m-mohr commented Jun 9, 2020

Sounds like that. Should we adopt the specification of aggregate_spatial (fka aggregate_polygon)?

@soxofaan
Copy link
Member

soxofaan commented Jun 2, 2021

(ping)

In the mean time, we actually have a couple of example notebooks, demo's and videos (against the VITO backend) that illustrate this 'multiband' aggregated time series feature, which is strictly speaking violating the spec.

@m-mohr m-mohr linked a pull request Sep 7, 2022 that will close this issue
14 tasks
@m-mohr
Copy link
Member Author

m-mohr commented Sep 7, 2022

This will be implemented in 2.0.0. See #382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking help wanted Extra attention is needed vector
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants