Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify save_result return value #401

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Clarify save_result return value #401

merged 2 commits into from
Mar 14, 2023

Conversation

m-mohr
Copy link
Member

@m-mohr m-mohr commented Jan 31, 2023

Fixes #334

@m-mohr m-mohr added this to the 2.0.0 milestone Jan 31, 2023
@m-mohr m-mohr requested a review from soxofaan January 31, 2023 16:14
@m-mohr m-mohr linked an issue Jan 31, 2023 that may be closed by this pull request
save_result (and save_model): Is the boolean return value useful at all? #334
Closed
@m-mohr m-mohr changed the base branch from draft-2.0 to draft February 1, 2023 17:17
@soxofaan
Copy link
Member

@jdries FYI: we discussed this earlier

@m-mohr
Copy link
Member Author

m-mohr commented Mar 14, 2023

Seems to be okay for being more future-proof.

@soxofaan soxofaan mentioned this pull request Mar 14, 2023
Closed
@m-mohr m-mohr changed the title Clarify save_result (and save_ml_model) return value Clarify save_result return value Mar 14, 2023
@m-mohr
Copy link
Member Author

m-mohr commented Mar 14, 2023

Ready for review

@m-mohr m-mohr merged commit 6fadb68 into draft Mar 14, 2023
@m-mohr m-mohr deleted the issue-334 branch March 14, 2023 17:15
@soxofaan soxofaan mentioned this pull request Mar 24, 2023
Open
clausmichele
clausmichele reviewed Mar 27, 2023
View reviewed changes
Copy link
Member

@clausmichele clausmichele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clausmichele clausmichele clausmichele left review comments

@mkadunc mkadunc mkadunc approved these changes

@soxofaan soxofaan Awaiting requested review from soxofaan

@dthiex dthiex Awaiting requested review from dthiex

@jdries jdries Awaiting requested review from jdries

@LukeWeidenwalker LukeWeidenwalker Awaiting requested review from LukeWeidenwalker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0-rc.2
Development

Successfully merging this pull request may close these issues.

save_result (and save_model): Is the boolean return value useful at all?
4 participants
@m-mohr @soxofaan @mkadunc @clausmichele