From e1989c4339a68a48fa331b8c502b23b61a48426c Mon Sep 17 00:00:00 2001
From: Pierre Chelle <45343665+pchelle@users.noreply.github.com>
Date: Thu, 20 Oct 2022 09:26:20 -0400
Subject: [PATCH] Fixes #878 yAxis normalization of residuals distribution
 (#943)

---
 R/gof-plot-task.R             | 3 ++-
 R/reportingengine-env.R       | 2 +-
 R/utilities-goodness-of-fit.R | 3 ++-
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/R/gof-plot-task.R b/R/gof-plot-task.R
index 6ef69797..6daefa5d 100644
--- a/R/gof-plot-task.R
+++ b/R/gof-plot-task.R
@@ -425,7 +425,8 @@ GofPlotTask <- R6::R6Class(
             x = "Residuals",
             fill = "Legend",
             stack = TRUE,
-            distribution = "normal"
+            distribution = "normal",
+            frequency = TRUE
           ),
           plotConfiguration = settings$plotConfigurations[["histogram"]],
           bins = settings$bins %||% reEnv$defaultBins
diff --git a/R/reportingengine-env.R b/R/reportingengine-env.R
index a88d0d26..45656530 100644
--- a/R/reportingengine-env.R
+++ b/R/reportingengine-env.R
@@ -58,7 +58,7 @@ reEnv$defaultPlotFormat <- list(
 reEnv$fontScaleFactor <- 2
 
 reEnv$workflowWatermarkMessage <- "preliminary analysis"
-reEnv$residualsHistogramLabel <- "Number of residuals"
+reEnv$residualsHistogramLabel <- "Relative frequency"
 reEnv$residualsQQLabel <- "Quantiles of residuals"
 
 # Default values for qualification pk ratio
diff --git a/R/utilities-goodness-of-fit.R b/R/utilities-goodness-of-fit.R
index e840fe34..7ef14a6b 100644
--- a/R/utilities-goodness-of-fit.R
+++ b/R/utilities-goodness-of-fit.R
@@ -1223,7 +1223,8 @@ getResidualsPlotResults <- function(timeRange, residualsData, metaDataFrame, str
       x = "Residuals",
       fill = "Legend",
       stack = TRUE,
-      distribution = "normal"
+      distribution = "normal",
+      frequency = TRUE
     ),
     plotConfiguration = settings$plotConfigurations[["resHisto"]],
     bins = settings$bins %||% reEnv$defaultBins