From 19f61d016bf5292209164618fbc70424ce2fbc0f Mon Sep 17 00:00:00 2001
From: Fabian Arndt <fabian.arndt@root-core.net>
Date: Sun, 13 Oct 2024 22:38:54 +0200
Subject: [PATCH] Refactor: match is not supported in Python 3.9

---
 config_base.py | 43 +++++++++++++++++++++++++------------------
 1 file changed, 25 insertions(+), 18 deletions(-)

diff --git a/config_base.py b/config_base.py
index 4caf39c0..232c26b9 100644
--- a/config_base.py
+++ b/config_base.py
@@ -6,6 +6,9 @@
 from dataclasses import dataclass, is_dataclass
 from pathlib import Path
 
+from typing import Any
+from collections.abc import Callable
+
 from logger import log, LogLevelType
 
 class ConfigBase:
@@ -50,7 +53,7 @@ def init_sections(self, force: bool = False) -> None:
                 continue
 
             # Initialize section class as a member
-            setattr(self, section_name, member())
+            setattr(self, section_name, member()) # pyright: ignore [reportCallIssue]
 
 
     def parse_config_file(self, file: Path) -> bool:
@@ -72,25 +75,29 @@ def parse_config_file(self, file: Path) -> bool:
 
                 parser_items = parser[section_name]
 
+                # FIXME: match is not supported in Python 3.9
+                def _get_parse_function(type_name: str) -> Callable[[str], Any]:
+                    # Mapping of type_name to according value get function
+                    value = {
+                        'int': parser_items.getint,
+                        'float': parser_items.getfloat,
+                        'bool': parser_items.getboolean,
+                        'Path': lambda option: Path(parser_items.get(option, '')),
+                        'PosixPath': lambda option: Path(parser_items.get(option, '')),
+                        'str': parser_items.get
+                    }.get(type_name, None)
+                    if not value:
+                        value = parser_items.get
+                        self.__log(f'Unknown type "{type_name}", falling back to "str".')
+                    return value
+
                 # Iterate over the option objects in this section
                 for (option_name, option_item) in section.__dict__.items():
-                    # Match type of local object
-                    match type(option_item).__name__:
-                        case 'int':
-                            setattr(section, option_name, parser_items.getint(option_name))
-                        case 'float':
-                            setattr(section, option_name, parser_items.getfloat(option_name))
-                        case 'bool':
-                            setattr(section, option_name, parser_items.getboolean(option_name))
-                        case 'Path':
-                            setattr(section, option_name, Path(parser_items.get(option_name)))
-                        case 'PosixPath':
-                            setattr(section, option_name, Path(parser_items.get(option_name)))
-                        case 'str':
-                            setattr(section, option_name, parser_items.get(option_name))
-                        case _:
-                            setattr(section, option_name, parser_items.get(option_name))
-                            self.__log(f'[CONFIG]: Type mismatch')
+                    # Get values from config and set it on object
+                    type_name = type(option_item).__name__
+                    func = _get_parse_function(type_name)
+                    value = func(option_name)
+                    setattr(section, option_name, value)
         except Exception as ex:
             self.__log(f'Failed to parse config file "{file}". Exception: "{ex}"', 'CRIT')
             return False