chore(deps): upgrade @nestjs/axios to 3.0.1

[UR-deR]

update @nestjs/axios and other packages with incorrect peer dependency

---

fix #719

[wvanderdeijl]

I wouldn't recommended updating nx directly in the package.json. Shouldn't we use nx migrate (https://nx.dev/core-features/automate-updating-dependencies) as that usually does much more work than just updating dependencies.

[UR-deR]

I'm sorry, I should have read nx's document and shouldn't include nx update in this PR.
I only updated something related to the issue

[alexan]

why do you set a specific axios version here? If you leave it out using projects can just set their own axios version in future.
If it needed for testing it should just be added to devDependencies like on @nestjs/axios then the axios version would no "bleed" to child projects

[UR-deR]

Testing can be done without it.
But if I remove axios, an warning occurs like below.

warning " > @nestjs/axios@3.0.1" has unmet peer dependency "axios@^1.3.1"

Is it okay to ignore this or should I add axios to devDependencies?

[alexan]

as this is a library I would say this warning is okay as the consuming package should install its axios version

[UR-deR]

I see, I removed axios from dependencies

[manan19]

Thanks for putting this together. Will it be released after this PR is merged? context GHSA-wf5p-g6vw-rhxx

[wing328]

CI failed: https://github.com/OpenAPITools/openapi-generator-cli/actions/runs/6955846991/job/19127935712?pr=722

can you please take a look when you've time?

thanks again for the PR.

[UR-deR]

@wing328
I made some changes, could you rerun ci workflow?
Same error occurred on my local, but now it runs without failing.

[wing328]

still some failed tests: https://github.com/OpenAPITools/openapi-generator-cli/actions/runs/7077821666/job/19262635518?pr=722

please take a look when you've time

[UR-deR]

@wing328
Could you rerun workflow? I am not sure it will work well
thank you for your help

[wing328]

Just reran the workflow. Let's see how that goes

[wing328]

unfortunately the tests still failed:

Done in 9.16s.

> examples@1.0.0 oa
> openapi-generator-cli version

node:internal/modules/cjs/loader:1080
  throw err;
  ^

Error: Cannot find module 'axios'
Require stack:
- /home/runner/work/openapi-generator-cli/openapi-generator-cli/examples/node_modules/@nestjs/axios/dist/http.module.js
- /home/runner/work/openapi-generator-cli/openapi-generator-cli/examples/node_modules/@nestjs/axios/dist/index.js
- /home/runner/work/openapi-generator-cli/openapi-generator-cli/examples/node_modules/@nestjs/axios/index.js
- /home/runner/work/openapi-generator-cli/openapi-generator-cli/examples/node_modules/@openapitools/openapi-generator-cli/main.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1077:15)
    at Module._load (node:internal/modules/cjs/loader:922:27)
    at Module.require (node:internal/modules/cjs/loader:1[143](https://github.com/OpenAPITools/openapi-generator-cli/actions/runs/7102942856/job/19409541420?pr=722#step:5:144):19)
    at require (node:internal/modules/cjs/helpers:119:18)
    at Object.<anonymous> (/home/runner/work/openapi-generator-cli/openapi-generator-cli/examples/node_modules/@nestjs/axios/dist/http.module.js:16:33)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at Module.require (node:internal/modules/cjs/loader:1143:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/runner/work/openapi-generator-cli/openapi-generator-cli/examples/node_modules/@nestjs/axios/dist/http.module.js',
    '/home/runner/work/openapi-generator-cli/openapi-generator-cli/examples/node_modules/@nestjs/axios/dist/index.js',
    '/home/runner/work/openapi-generator-cli/openapi-generator-cli/examples/node_modules/@nestjs/axios/index.js',
    '/home/runner/work/openapi-generator-cli/openapi-generator-cli/examples/node_modules/@openapitools/openapi-generator-cli/main.js'

[UR-deR]

@wing328 Sorry for taking a while to fix ci failure.
I would like you to rerun the workflow

[UR-deR]

@wing328
Could you run workflow again🙏
I found a warning which may cause ci error and changed axios version specification

warning "/home/runner/work/openapi-generator-cli/openapi-generator-cli/package.tgz > @nestjs/axios@3.0.1" has unmet peer dependency "axios@^1.3.1".

[wing328]

done but the tests still failed with the same error message

[UR-deR]

@wing328
I changed jest config like #719 (comment)
I wanna see how the workflow goes

[wing328]

done but got the same error

[simonhammes]

I don't know a lot about NX, but this seems like a bug in NX related to the implicit dependency functionality.

axios was specified as a direct dependency as part of this PR, but it does not get added to the generated package.json, which causes the MODULE_NOT_FOUND errors in CI.

See https://github.com/OpenAPITools/openapi-generator-cli/actions/runs/7287055215/job/19881267299?pr=722#step:5:52

Maybe upgrading NX first would help? 🤷

Or is there a way to specify an explicit dependency with NX?

[wing328]

@simonhammes thanks for the suggestion

@axtx4869 can you please also update NX as part of this PR?

(I saw the comment from @wvanderdeijl before)

[elmarbeckmann]

Any updates on this issue? I see that NX (17.2.x) now has axios@1.6.5 as a dependency which fixes the vulnerability there.

[wing328]

@elmarbeckmann do you mind filing a PR on top of this change with the NX upgraded to newer version?

[elmarbeckmann]

@elmarbeckmann do you mind filing a PR on top of this change with the NX upgraded to newer version?

here you go, made a new PR. #730
dependencies were just a bit behind ;)

[wing328]

closed via #730