Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Time Format in pojo.mustache for DateTime Pattern #20291

Open
julianshess opened this issue Dec 11, 2024 · 2 comments
Open

Incorrect Time Format in pojo.mustache for DateTime Pattern #20291

julianshess opened this issue Dec 11, 2024 · 2 comments

Comments

@julianshess
Copy link

The current pojo.mustache template for the CXF Ext module in the OpenAPI generator seems to have an incorrect DateTime pattern in line 49:

@JsonFormat(shape = JsonFormat.Shape.STRING, pattern = "yyyy-MM-dd'T'hh:mm:ss.SSSX")

Problem:
The pattern uses hh for the hour, which refers to a 12-hour clock format (requiring AM/PM context). However, this context is not present in the pattern. If the goal is to format the time in 24-hour clock, the correct placeholder should be HH.

Suggestion:
Replace hh with HH to reflect the intended 24-hour time representation.

Thank you

@wing328
Copy link
Member

wing328 commented Dec 11, 2024

@julianshess thanks for reporting the issue

can you please file a PR to start with?

@julianshess
Copy link
Author

@wing328 sure, done with #20302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants