Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SyncProgress类中使用 ip + port 方式作为map key会有冲突问题 #2429

Closed
happy-v587 opened this issue Feb 29, 2024 · 1 comment
Closed
Labels
3.5.3 ☢️ Bug Something isn't working

Comments

@happy-v587
Copy link
Contributor

happy-v587 commented Feb 29, 2024

Is this a regression?

Yes

Description

SyncProgress 类中,有使用 ip + std::to_string(port) 的方式作为 map 的 key,存在key重复问题。

https://github.com/OpenAtomFoundation/pika/blob/unstable/src/pika_consensus.cc#L99

比如,如下两个ip和port信息,key都是 10.1.1.12379

10.1.1.1     2379
10.1.1.12     379

Please provide a link to a minimal reproduction of the bug

No response

Screenshots or videos

No response

Please provide the version you discovered this bug in (check about page for version information)

No response

Anything else?

No response

@happy-v587 happy-v587 added the ☢️ Bug Something isn't working label Feb 29, 2024
@AlexStocks
Copy link
Collaborator

@HappyUncle 如果你方便,尽快提个 PR 过来

happy-v587 added a commit to happy-v587/pika that referenced this issue Feb 29, 2024
OpenAtomFoundation#2429
Signed-off-by: HappyUncle <code4happy@gmail.com>
AlexStocks pushed a commit that referenced this issue Feb 29, 2024
#2429

Signed-off-by: HappyUncle <code4happy@gmail.com>
luky116 pushed a commit to luky116/pika that referenced this issue Mar 14, 2024
luky116 pushed a commit to luky116/pika that referenced this issue Mar 14, 2024
luky116 pushed a commit that referenced this issue Mar 18, 2024
#2429

Signed-off-by: HappyUncle <code4happy@gmail.com>
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this issue Jun 8, 2024
cheniujh pushed a commit to cheniujh/pika that referenced this issue Sep 24, 2024
cheniujh pushed a commit to cheniujh/pika that referenced this issue Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.5.3 ☢️ Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants