fix (#1587): show pika version #1588

ATX735 · 2023-06-05T02:58:34Z

No description provided.

cr-gpt · 2023-06-05T02:58:40Z

.gitignore

@@ -40,6 +40,7 @@ output/
 # DB
 db/
 dump/
+src/dbsync/

 # third party
 gdb.txt


Based on the code patch you provided, it seems that all you did was add a new directory called src/dbsync/ to your version control system.

As such, there is no code that needs reviewing for bugs or improvement suggestions. However, if you have any implementation concerns related to the contents of this new directory, please provide more information and I would be happy to help.

cr-gpt · 2023-06-05T02:58:45Z

src/pika.cc

@@ -120,6 +119,7 @@ static void usage() {
          "usage: pika [-hv] [-c conf/file]\n"
          "\t-h               -- show this help\n"
          "\t-c conf/file     -- config file \n"
+          "\t-v               -- show version\n"
          "  example: ./output/bin/pika -c ./conf/pika.conf\n",
          version);
 }


Overall, the code patch seems straightforward and free of major issues. Below are a few minor suggestions for improvement:

Remove unnecessary whitespace in Line 7 for better readability.

Consider adding comments to describe the function and purpose of the daemonize() and close_std() functions.

It may be helpful to provide more details about the version number in the usage string. For example, specifying whether it is the version of the program or its dependencies.

As for any bug risks, without further context on the larger program and its dependencies, it is difficult to determine if there are any critical implications to this code patch.

src/pika.cc

AlexStocks · 2023-06-05T03:29:14Z

have you finished this pr? If so, I will merge this pr after the github action ci completed.

ATX735 · 2023-06-05T03:34:24Z

have you finished this pr? If so, I will merge this pr after the github action ci completed.

sure

* feat: supported 'ptype' command * Simplified command `type` and `ptype` code * Remove the capacity judgment * fix slavaof serialize response bug (#1583) Co-authored-by: liuyuecai <liuyuecai@360.cn> * fix (#1587) (#1588) * fix unit test:type/set (#1577) * Fix memory leaks in HandleBGWorkerWriteDB and HandleMetaSyncResponse (#1590) * fix memory leaks in PikaReplBgWorker::HandleBGWorkerWriteDB(void* arg) and PikaReplClientConn::HandleMetaSyncResponse(void* arg). * add address/thread sanitizer to CMakeLists --------- Co-authored-by: cjh <1271435567@qq.com> * refactor: replace pstd/env with std::filesystem (#1470) * fix bug issue 1554: using unique_ptr.reset to fix the SIGABRT error (#1595) using unique_ptr.reset to fix the SIGABRT error && using time-wait lock to notify quickly * fix: incorrect manner of terminating the process (#1596) * fix issue#1597: add rocksdb dependency to pstd (#1599) * fix g++15 compile failure * add rocksdb dependency to pstd --------- Co-authored-by: J1senn <J1senn@outlook.com> * fix_info_command * fix: gcc13 compile failed (#1601) * ci: add unit test to github action (#1604) * ci: add unit test in github workflow * chore:change `PLATFORM` field logic (#1615) * fix issue 1517: scan 命令不支持 type 参数 (#1582) * fix: the unit test of type/set (#1617) * test: optimize the return results of srandmember to avoid approximate results * fix: use last_seed for random engine * [fix issue1621] fix deadlock (#1620) * [fix] fix deadlock * [fix] fix * command `type` and `ptype` add unit test * fix member variable initialization * Update issue templates * feat: supported 'ptype' command * fix unit test:type/set (#1577) * fix issue#1597: add rocksdb dependency to pstd (#1599) * fix g++15 compile failure * add rocksdb dependency to pstd --------- Co-authored-by: J1senn <J1senn@outlook.com> * fix: gcc13 compile failed (#1601) * fix: the unit test of type/set (#1617) * test: optimize the return results of srandmember to avoid approximate results * fix: use last_seed for random engine * Modify other modules to use the new `type` function * fix function repeat --------- Co-authored-by: Yuecai Liu <38887641+luky116@users.noreply.github.com> Co-authored-by: liuyuecai <liuyuecai@360.cn> Co-authored-by: Peter Chan <luckygoose@foxmail.com> Co-authored-by: chenbt <34958405+chenbt-hz@users.noreply.github.com> Co-authored-by: Junhua Chen <41671101+cheniujh@users.noreply.github.com> Co-authored-by: cjh <1271435567@qq.com> Co-authored-by: kang jinci <jincikang@gmail.com> Co-authored-by: Xin.Zh <dragoncharlie@foxmail.com> Co-authored-by: machinly <machinlyg@gmail.com> Co-authored-by: A2ureStone <73770413+A2ureStone@users.noreply.github.com> Co-authored-by: J1senn <J1senn@outlook.com> Co-authored-by: chejinge <945997690@qq.com> Co-authored-by: baerwang <52104949+baerwang@users.noreply.github.com> Co-authored-by: ptbxzrt <89020404+ptbxzrt@users.noreply.github.com> Co-authored-by: 你不要过来啊 <73388438+iiiuwioajdks@users.noreply.github.com>

* feat: supported 'ptype' command * Simplified command `type` and `ptype` code * Remove the capacity judgment * fix slavaof serialize response bug (OpenAtomFoundation#1583) Co-authored-by: liuyuecai <liuyuecai@360.cn> * fix (OpenAtomFoundation#1587) (OpenAtomFoundation#1588) * fix unit test:type/set (OpenAtomFoundation#1577) * Fix memory leaks in HandleBGWorkerWriteDB and HandleMetaSyncResponse (OpenAtomFoundation#1590) * fix memory leaks in PikaReplBgWorker::HandleBGWorkerWriteDB(void* arg) and PikaReplClientConn::HandleMetaSyncResponse(void* arg). * add address/thread sanitizer to CMakeLists --------- Co-authored-by: cjh <1271435567@qq.com> * refactor: replace pstd/env with std::filesystem (OpenAtomFoundation#1470) * fix bug issue 1554: using unique_ptr.reset to fix the SIGABRT error (OpenAtomFoundation#1595) using unique_ptr.reset to fix the SIGABRT error && using time-wait lock to notify quickly * fix: incorrect manner of terminating the process (OpenAtomFoundation#1596) * fix issue#1597: add rocksdb dependency to pstd (OpenAtomFoundation#1599) * fix g++15 compile failure * add rocksdb dependency to pstd --------- Co-authored-by: J1senn <J1senn@outlook.com> * fix_info_command * fix: gcc13 compile failed (OpenAtomFoundation#1601) * ci: add unit test to github action (OpenAtomFoundation#1604) * ci: add unit test in github workflow * chore:change `PLATFORM` field logic (OpenAtomFoundation#1615) * fix issue 1517: scan 命令不支持 type 参数 (OpenAtomFoundation#1582) * fix: the unit test of type/set (OpenAtomFoundation#1617) * test: optimize the return results of srandmember to avoid approximate results * fix: use last_seed for random engine * [fix issue1621] fix deadlock (OpenAtomFoundation#1620) * [fix] fix deadlock * [fix] fix * command `type` and `ptype` add unit test * fix member variable initialization * Update issue templates * feat: supported 'ptype' command * fix unit test:type/set (OpenAtomFoundation#1577) * fix issue#1597: add rocksdb dependency to pstd (OpenAtomFoundation#1599) * fix g++15 compile failure * add rocksdb dependency to pstd --------- Co-authored-by: J1senn <J1senn@outlook.com> * fix: gcc13 compile failed (OpenAtomFoundation#1601) * fix: the unit test of type/set (OpenAtomFoundation#1617) * test: optimize the return results of srandmember to avoid approximate results * fix: use last_seed for random engine * Modify other modules to use the new `type` function * fix function repeat --------- Co-authored-by: Yuecai Liu <38887641+luky116@users.noreply.github.com> Co-authored-by: liuyuecai <liuyuecai@360.cn> Co-authored-by: Peter Chan <luckygoose@foxmail.com> Co-authored-by: chenbt <34958405+chenbt-hz@users.noreply.github.com> Co-authored-by: Junhua Chen <41671101+cheniujh@users.noreply.github.com> Co-authored-by: cjh <1271435567@qq.com> Co-authored-by: kang jinci <jincikang@gmail.com> Co-authored-by: Xin.Zh <dragoncharlie@foxmail.com> Co-authored-by: machinly <machinlyg@gmail.com> Co-authored-by: A2ureStone <73770413+A2ureStone@users.noreply.github.com> Co-authored-by: J1senn <J1senn@outlook.com> Co-authored-by: chejinge <945997690@qq.com> Co-authored-by: baerwang <52104949+baerwang@users.noreply.github.com> Co-authored-by: ptbxzrt <89020404+ptbxzrt@users.noreply.github.com> Co-authored-by: 你不要过来啊 <73388438+iiiuwioajdks@users.noreply.github.com>

fix (OpenAtomFoundation#1587)

fe60eaf

cr-gpt bot reviewed Jun 5, 2023

View reviewed changes

AlexStocks reviewed Jun 5, 2023

View reviewed changes

src/pika.cc Show resolved Hide resolved

AlexStocks changed the title ~~fix (#1587)~~ fix (#1587): show pika version Jun 5, 2023

AlexStocks approved these changes Jun 5, 2023

View reviewed changes

AlexStocks merged commit 84819fe into OpenAtomFoundation:unstable Jun 5, 2023

lqxhub pushed a commit to lqxhub/pika that referenced this pull request Jun 18, 2023

fix (OpenAtomFoundation#1587) (OpenAtomFoundation#1588)

e691134

bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this pull request Jun 8, 2024

fix (OpenAtomFoundation#1587) (OpenAtomFoundation#1588)

1dc651d

cheniujh pushed a commit to cheniujh/pika that referenced this pull request Sep 24, 2024

fix (OpenAtomFoundation#1587) (OpenAtomFoundation#1588)

33928a0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix (#1587): show pika version #1588

fix (#1587): show pika version #1588

ATX735 commented Jun 5, 2023

cr-gpt bot Jun 5, 2023

cr-gpt bot Jun 5, 2023

AlexStocks commented Jun 5, 2023

ATX735 commented Jun 5, 2023

fix (#1587): show pika version #1588

fix (#1587): show pika version #1588

Conversation

ATX735 commented Jun 5, 2023

cr-gpt bot Jun 5, 2023

Choose a reason for hiding this comment

cr-gpt bot Jun 5, 2023

Choose a reason for hiding this comment

AlexStocks commented Jun 5, 2023

ATX735 commented Jun 5, 2023