-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ci replication go test failed problem #2435
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexStocks
reviewed
Mar 1, 2024
AlexStocks
reviewed
Mar 1, 2024
AlexStocks
reviewed
Mar 1, 2024
AlexStocks
reviewed
Mar 1, 2024
AlexStocks
reviewed
Mar 1, 2024
AlexStocks
reviewed
Mar 1, 2024
AlexStocks
approved these changes
Mar 2, 2024
luky116
reviewed
Mar 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
luky116
pushed a commit
to luky116/pika
that referenced
this pull request
Mar 14, 2024
Co-authored-by: wuxianrong <wuxianrong@360.cn>
luky116
pushed a commit
to luky116/pika
that referenced
this pull request
Mar 14, 2024
Co-authored-by: wuxianrong <wuxianrong@360.cn>
luky116
pushed a commit
that referenced
this pull request
Mar 18, 2024
Co-authored-by: wuxianrong <wuxianrong@360.cn>
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
Co-authored-by: wuxianrong <wuxianrong@360.cn>
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
Co-authored-by: wuxianrong <wuxianrong@360.cn>
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
Co-authored-by: wuxianrong <wuxianrong@360.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
由于在之前线上的 ci 中主从测试经常出现测试失败的问题,在本 PR 中我们把集成测试和主从的测试进行了拆分,对于单机的集成测试我们使用
9221
端口,对于Pika
的主从测试,我们使用了9231
和9241
作为端口进行主从测试,确保环境干净,目前在Mac
本机上测试通过率为100%
并且稳定Since the master-slave test often failed in the previous online ci, we split the integration test and the master-slave test in this PR. For the stand-alone integration test, we used the '9221' port. For the master-slave test of 'Pika', we used the '9221' port. We used '9231' and '9241' as ports for master-slave testing to ensure a clean environment, and the current test pass rate on 'Mac' is' 100% 'and stable
#2356