Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When updating an expectation score, the expectation status doesn't change #1350

Closed
jborozco opened this issue Aug 27, 2024 · 1 comment · Fixed by #1379
Closed

When updating an expectation score, the expectation status doesn't change #1350

jborozco opened this issue Aug 27, 2024 · 1 comment · Fixed by #1379
Assignees
Labels
bug use for describing something not working as expected solved The issue has been solved
Milestone

Comments

@jborozco
Copy link

Description

Expectation status should be updated to failed if the score is updated
image

Reproducible Steps

  1. go to https://testing.obas.staging.filigran.io/admin/exercises/96892d44-ce23-4045-9fe4-68a9d849a0b9/injects/d17fa25c-21e5-49ff-a78c-4da9ea9c46f2
  2. modify expectation score to 90

Expected Output

the status should be "failed"

Actual Output

The status is still "success"

@jborozco jborozco added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team and removed needs triage use to identify issue needing triage from Filigran Product team labels Aug 27, 2024
@jborozco jborozco added this to the Bugs backlog milestone Aug 27, 2024
@MarineLeM MarineLeM self-assigned this Aug 29, 2024
@MarineLeM
Copy link
Contributor

I found 2 other problems on this topics. Here are the two use cases:

Problem 1 :
Prerequisite : Set the inject expectation mode to 'at least one player need to validate' with an expected score of 80. Assign team with at least one player
Observation : if you set the score to more than 0 the inject expectation status will always be 'Success'
Expected Output : If the score is set below the expected score (80 in this example) the status should be 'Failed'

Problem 2 :
Prerequisite : Set the inject expectation mode to 'all players need to validate' with an expected score of 80. Assign a team with 2 players.
Observation : if you set the score of first player to 79 and the score of the second player to 100. The inject expectation status for the team shows as 'Success.'
Expected Output : The inject expectation status for the team should be 'failed' because one of the players did not meet the expected score, even though the average score of the two players is higher than the expected score.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected solved The issue has been solved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants