Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Add sortable property to team_name #1399

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

savacano28
Copy link
Contributor

Proposed changes

  • Add property sortabele to team_name: Error : Uncaught (in promise)
    Object { status: 500, timestamp: "2024-09-09T07:51:37.558+00:00", error: "Internal Server Error", path: "/api/teams/search" }

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Sep 9, 2024
@savacano28 savacano28 self-assigned this Sep 9, 2024
@savacano28 savacano28 marked this pull request as ready for review September 9, 2024 08:14
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.35%. Comparing base (121abff) to head (38fd935).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1399      +/-   ##
============================================
+ Coverage     30.12%   30.35%   +0.23%     
- Complexity     1356     1360       +4     
============================================
  Files           523      523              
  Lines         13654    13654              
  Branches        806      806              
============================================
+ Hits           4113     4145      +32     
+ Misses         9347     9315      -32     
  Partials        194      194              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 merged commit 5dfacdc into master Sep 9, 2024
7 checks passed
guillaumejparis pushed a commit that referenced this pull request Sep 9, 2024
@savacano28 savacano28 deleted the bugfix/sortable-team-name branch September 9, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants