Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backend/frontend] Fix team creation #1402

Merged
merged 2 commits into from
Sep 9, 2024
Merged

[backend/frontend] Fix team creation #1402

merged 2 commits into from
Sep 9, 2024

Conversation

RomuDeuxfois
Copy link
Member

@RomuDeuxfois RomuDeuxfois linked an issue Sep 9, 2024 that may be closed by this pull request
Teams creation does not work #1398
Closed
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Sep 9, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 30.67%. Comparing base (5dfacdc) to head (c041f3f).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...pi/src/main/java/io/openbas/rest/team/TeamApi.java 0.00% 13 Missing ⚠️
...enbas/rest/exception/AlreadyExistingException.java 0.00% 4 Missing ⚠️
...main/java/io/openbas/rest/helper/RestBehavior.java 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1402      +/-   ##
============================================
+ Coverage     30.12%   30.67%   +0.54%     
- Complexity     1356     1381      +25     
============================================
  Files           523      524       +1     
  Lines         13654    13677      +23     
  Branches        806      807       +1     
============================================
+ Hits           4113     4195      +82     
+ Misses         9347     9291      -56     
+ Partials        194      191       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

savacano28
savacano28 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@savacano28 savacano28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ok

@RomuDeuxfois RomuDeuxfois merged commit d2937b3 into master Sep 9, 2024
7 checks passed
@RomuDeuxfois RomuDeuxfois deleted the issue/1398 branch September 9, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EllynBsc EllynBsc EllynBsc left review comments

@Dimfacion Dimfacion Dimfacion left review comments

@savacano28 savacano28 savacano28 approved these changes

Assignees
No one assigned
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Teams creation does not work
4 participants
@RomuDeuxfois @savacano28 @Dimfacion @EllynBsc