Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend/backend] add a start now for scenario (#1368) #1405

Merged
merged 11 commits into from
Sep 12, 2024
Merged

[frontend/backend] add a start now for scenario (#1368) #1405

merged 11 commits into from
Sep 12, 2024

Conversation

guillaumejparis
Copy link
Member

@guillaumejparis guillaumejparis commented Sep 9, 2024 •
edited by RomuDeuxfois
Loading

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Sep 9, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.99160% with 50 lines in your changes missing coverage. Please review.

Project coverage is 31.41%. Comparing base (71df858) to head (de02c2f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ain/java/io/openbas/rest/scenario/ScenarioApi.java 47.54% 31 Missing and 1 partial ⚠️
.../io/openbas/service/ScenarioToExerciseService.java 89.77% 16 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1405      +/-   ##
============================================
- Coverage     31.42%   31.41%   -0.01%     
  Complexity     1407     1407              
============================================
  Files           525      525              
  Lines         13678    13682       +4     
  Branches        807      808       +1     
============================================
  Hits           4298     4298              
- Misses         9182     9185       +3     
- Partials        198      199       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomuDeuxfois
Copy link
Member

RomuDeuxfois commented Sep 10, 2024 •
edited
Loading

Not part of your issue, but this is not translate in scenario
image

If I select the hour at now, the error message it not present on the dialog
image

The feature works as requested

@RomuDeuxfois
Copy link
Member

When I start the application and go to the login page
I have this
image

Previous feedbacks are fixed.

@guillaumejparis guillaumejparis merged commit 8d75ef9 into master Sep 12, 2024
7 checks passed
@guillaumejparis guillaumejparis deleted the issue/1368 branch September 12, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomuDeuxfois RomuDeuxfois RomuDeuxfois approved these changes

Assignees
No one assigned
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guillaumejparis @RomuDeuxfois