[backend/frontend] Add possibility to launch openbas agent on docker and linux image #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
filigran team
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1417 +/- ##
============================================
- Coverage 31.42% 31.41% -0.01%
Complexity 1407 1407
============================================
Files 525 525
Lines 13678 13680 +2
Branches 807 807
============================================
Hits 4298 4298
- Misses 9182 9184 +2
Partials 198 198 ☔ View full report in Codecov by Sentry. |
damgouj
approved these changes
Sep 12, 2024
|
If anyone additional can go through the documentation and testing part, it would be great thx ! |
savacano28
reviewed
Sep 12, 2024
|
|
||
| @JsonProperty("application_agent_url") | ||
| private String agentUrl; | ||
|
|
There was a problem hiding this comment.
Do we need to add this to the properties file, or should we set it on the platform settings page?
There was a problem hiding this comment.
In the application-dev.properties yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Add possibility to launch openbas agent on docker and linux image.
Add a new property to change the base agent url to deploy agent on docker
openbas.agent-url=http://host.docker.internal:8080Add a new internal documentation for Windows user to deploy openbas agent on linux image