Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] Filters options should not be limit to 10 #1430

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

RomuDeuxfois
Copy link
Member

  • Problem: Filters show only 10 random entries
    • Should show all entries
    • Should be ordered alphabetically

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 31.32%. Comparing base (250b2f8) to head (5457b35).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../openbas/rest/attack_pattern/AttackPatternApi.java 0.00% 1 Missing ⚠️
...ain/java/io/openbas/rest/injector/InjectorApi.java 0.00% 1 Missing ⚠️
...enbas/rest/kill_chain_phase/KillChainPhaseApi.java 0.00% 1 Missing ⚠️
...ain/java/io/openbas/rest/scenario/ScenarioApi.java 0.00% 1 Missing ⚠️
...-api/src/main/java/io/openbas/rest/tag/TagApi.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1430   +/-   ##
=========================================
  Coverage     31.32%   31.32%           
  Complexity     1400     1400           
=========================================
  Files           526      526           
  Lines         13693    13693           
  Branches        814      814           
=========================================
  Hits           4289     4289           
  Misses         9204     9204           
  Partials        200      200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomuDeuxfois RomuDeuxfois merged commit b2674d0 into master Sep 13, 2024
7 checks passed
@RomuDeuxfois RomuDeuxfois deleted the bugfix/filters-option branch September 13, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants