Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Improv filter style #1433

Merged
merged 2 commits into from
Sep 16, 2024
Merged

[frontend] Improv filter style #1433

merged 2 commits into from
Sep 16, 2024

Conversation

RomuDeuxfois
Copy link
Member

  • Filters in list of payload in an inject “Target players only” doesn’t work if the filter injector is removed
  • When a filter is empty, it should look like in openCTI , the whole text is clickable not only “Content”:

image

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Sep 13, 2024
@RomuDeuxfois RomuDeuxfois merged commit 6e782f9 into master Sep 16, 2024
5 checks passed
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.32%. Comparing base (b2674d0) to head (7ca3efc).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1433   +/-   ##
=========================================
  Coverage     31.32%   31.32%           
  Complexity     1400     1400           
=========================================
  Files           526      526           
  Lines         13693    13693           
  Branches        814      814           
=========================================
  Hits           4289     4289           
  Misses         9204     9204           
  Partials        200      200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomuDeuxfois RomuDeuxfois deleted the bugfix/filter-style branch September 16, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants