Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Fix wrong count for pagination #1529

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

RomuDeuxfois
Copy link
Member

Proposed changes

  • Add distinct on pagination to avoir duplicate result and have a good counting

Here, the result and the count is not aligned
image

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.55%. Comparing base (7142c8b) to head (a9e7456).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1529   +/-   ##
=========================================
  Coverage     32.55%   32.55%           
  Complexity     1464     1464           
=========================================
  Files           534      534           
  Lines         13766    13766           
  Branches        824      824           
=========================================
  Hits           4482     4482           
  Misses         9075     9075           
  Partials        209      209           
Flag Coverage Δ
32.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomuDeuxfois RomuDeuxfois merged commit 3cd4a85 into master Sep 25, 2024
7 checks passed
@RomuDeuxfois RomuDeuxfois deleted the bugfix/counting branch September 25, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants