Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] clean caldera settings if executor is not enable #1559

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

MarineLeM
Copy link
Contributor

Signed-off-by: Marine LM <marine.lemezo@filigran.io>
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.77%. Comparing base (79deada) to head (883fdc1).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1559   +/-   ##
=========================================
  Coverage     32.76%   32.77%           
  Complexity     1502     1502           
=========================================
  Files           539      539           
  Lines         13883    13884    +1     
  Branches        824      824           
=========================================
+ Hits           4549     4550    +1     
+ Misses         9124     9123    -1     
- Partials        210      211    +1     
Flag Coverage Δ
32.77% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 self-requested a review September 27, 2024 15:41
Signed-off-by: Marine LM <marine.lemezo@filigran.io>
@savacano28 savacano28 self-requested a review September 27, 2024 16:04
@MarineLeM MarineLeM merged commit b19e019 into master Sep 30, 2024
7 checks passed
@MarineLeM MarineLeM deleted the issue/1550 branch September 30, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message of Caldera executor not responding when there is no Caldera config
2 participants