Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] Add filters on player page #1605

Merged
merged 7 commits into from
Oct 3, 2024
Merged

Conversation

RomuDeuxfois
Copy link
Member

Proposed changes

  • Add filters on player page
  • Change the query mechanism to use Criteria Builder instead of JPA

Related issues

Metrics

Mechanism Time
JPA 12.3 ms
CriteriaBuilder 4.3 ms

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 2.32558% with 84 lines in your changes missing coverage. Please review.

Project coverage is 32.33%. Comparing base (7a3f329) to head (d1eb733).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
...n/java/io/openbas/rest/user/PlayerQueryHelper.java 0.00% 32 Missing ⚠️
.../main/java/io/openbas/rest/user/PlayerService.java 3.57% 27 Missing ⚠️
...io/openbas/rest/user/form/player/PlayerOutput.java 0.00% 12 Missing ⚠️
.../io/openbas/rest/organization/OrganizationApi.java 0.00% 8 Missing ⚠️
...pi/src/main/java/io/openbas/aop/LoggingAspect.java 0.00% 4 Missing ⚠️
.../src/main/java/io/openbas/rest/user/PlayerApi.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1605      +/-   ##
============================================
- Coverage     32.59%   32.33%   -0.27%     
+ Complexity     1504     1499       -5     
============================================
  Files           540      543       +3     
  Lines         13981    14057      +76     
  Branches        836      841       +5     
============================================
- Hits           4557     4545      -12     
- Misses         9213     9301      +88     
  Partials        211      211              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomuDeuxfois RomuDeuxfois marked this pull request as ready for review October 1, 2024 18:22
@damgouj damgouj self-requested a review October 2, 2024 14:01
Copy link
Member

@damgouj damgouj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments in your code.
I tested the feature, all seem OK 👍.

@RomuDeuxfois RomuDeuxfois merged commit 3b195c5 into master Oct 3, 2024
5 checks passed
@RomuDeuxfois RomuDeuxfois deleted the issue/1555 branch October 3, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants