Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] Categorize payload by architecture #1612

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Conversation

isselparra
Copy link
Member

@isselparra isselparra commented Oct 3, 2024

Proposed changes

  • Give the opportunity for a user to declare the compatible architecture of an Executable Payload.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 83.78378% with 6 lines in your changes missing coverage. Please review.

Project coverage is 32.96%. Comparing base (43dc264) to head (ba4a7b3).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../main/java/io/openbas/rest/payload/PayloadApi.java 80.00% 2 Missing and 2 partials ⚠️
...api/src/main/java/io/openbas/schema/SchemaApi.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1612      +/-   ##
============================================
+ Coverage     32.45%   32.96%   +0.51%     
- Complexity     1510     1557      +47     
============================================
  Files           545      546       +1     
  Lines         14134    14156      +22     
  Branches        843      845       +2     
============================================
+ Hits           4587     4667      +80     
+ Misses         9331     9270      -61     
- Partials        216      219       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isselparra isselparra force-pushed the issue/1189 branch 2 times, most recently from 247c7bd to e1d382f Compare October 7, 2024 13:17
@isselparra isselparra marked this pull request as ready for review October 7, 2024 15:14
@isselparra isselparra self-assigned this Oct 7, 2024
@isselparra isselparra merged commit 6e516e1 into master Oct 16, 2024
7 checks passed
@isselparra isselparra deleted the issue/1189 branch October 16, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Categorize payload by architecture
2 participants