Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fixing default value of payload argument not set up #1675

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

Dimfacion
Copy link
Member

@Dimfacion Dimfacion commented Oct 17, 2024

Proposed changes

  • Fixing default value of payload argument not set up when the inject content block is not open

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Oct 17, 2024
@Dimfacion Dimfacion changed the title [frontend] Fixing default value of payload argument not set up when t… [frontend] Fixing default value of payload argument not set up Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.08%. Comparing base (946652b) to head (c0cb303).
Report is 5 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1675      +/-   ##
============================================
- Coverage     33.15%   33.08%   -0.07%     
- Complexity     1586     1617      +31     
============================================
  Files           551      558       +7     
  Lines         14430    14682     +252     
  Branches        873      898      +25     
============================================
+ Hits           4784     4858      +74     
- Misses         9425     9604     +179     
+ Partials        221      220       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dimfacion Dimfacion merged commit 7f3f846 into master Oct 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default value of payload argument is not taken into account when creating an atomic testing
2 participants