Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend] Remove duplicate requests for pagination & filters #1683

Merged
merged 3 commits into from
Oct 18, 2024
Merged

[frontend] Remove duplicate requests for pagination & filters #1683

merged 3 commits into from
Oct 18, 2024

Conversation

guillaumejparis
Copy link
Member

Close #1682

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Oct 18, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.28%. Comparing base (c377ffa) to head (fbf426f).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #1683   +/-   ##
=========================================
  Coverage     33.28%   33.28%           
  Complexity     1605     1605           
=========================================
  Files           557      557           
  Lines         14474    14474           
  Branches        871      871           
=========================================
  Hits           4817     4817           
  Misses         9435     9435           
  Partials        222      222

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isselparra isselparra self-requested a review October 18, 2024 10:01
@savacano28 savacano28 requested review from savacano28 and RomuDeuxfois and removed request for isselparra, RomuDeuxfois and savacano28 October 18, 2024 10:01
@isselparra isselparra self-requested a review October 18, 2024 11:52
@guillaumejparis guillaumejparis force-pushed the issue/1682 branch 2 times, most recently from ad89cee to c59760d Compare October 18, 2024 14:18
isselparra
isselparra approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@isselparra isselparra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: nice improvement 🤩 ❤️

for example, the payloads page

before (master, no stricmode):
Screenshot from 2024-10-18 16-21-11

after (issue/1682, no stricmode):
Screenshot from 2024-10-18 16-11-40

@guillaumejparis guillaumejparis merged commit b0a5e1a into master Oct 18, 2024
7 checks passed
@guillaumejparis guillaumejparis deleted the issue/1682 branch October 18, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isselparra isselparra isselparra approved these changes

@RomuDeuxfois RomuDeuxfois Awaiting requested review from RomuDeuxfois

Assignees
No one assigned
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove duplicate requests for pagination & filters
2 participants
@guillaumejparis @isselparra