Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BTHofmann2023 additions #305

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

BTHofmann2023 additions #305

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
5a8f9b0
expose parquet metadata
steinnymir Nov 21, 2023
684eb19
implement get_run_info and bugfix
steinnymir Nov 21, 2023
1606f06
augment info prints
steinnymir Nov 21, 2023
8c1ee97
augment info prints
steinnymir Nov 21, 2023
e0beeff
error catching for empty h5 channel
steinnymir Nov 22, 2023
264630c
fixed failing loading empty per_pulse channels
steinnymir Nov 22, 2023
0fbd2d9
filter dataframe prior to binning
steinnymir Nov 22, 2023
e8cd06a
catch numba typing error
steinnymir Nov 22, 2023
e776f33
add mono photon energy calculator
steinnymir Nov 23, 2023
c3a5f82
Merge branch 'main' into BTHofmann2023
steinnymir Nov 29, 2023
54305b6
Merge branch 'BTHofmann2023' into update_flsah_channels
steinnymir Dec 1, 2023
5a65e80
Merge pull request #306 from OpenCOMPES/update_flsah_channels
steinnymir Dec 1, 2023
b9e98d2
fix monochromator_photon_energy
steinnymir Dec 1, 2023
bf79089
inting
steinnymir Dec 1, 2023
702203f
remove unused function
steinnymir Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sed/binning/binning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,8 @@ def bin_dataframe(
xarray object, combining the data with the axes (bin centers).
"""
bins, axes, ranges = simplify_binning_arguments(bins, axes, ranges)

# filter dataframe to use only the columns needed for the binning
df = df[axes]
Comment on lines +296 to +297
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw this before in your commits. I don't think this is helpful, as it introduces another graph layer. Did you try whether this really improve computation time? In my tests, it slowed things down. Or why did you introduce this in the first place?

# create the coordinate axes for the xarray output
# if provided as array, they are interpreted as bin centers
if isinstance(bins[0], np.ndarray):
Expand Down
Loading