Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Csghub replace color design token #702

Merged
merged 5 commits into from
Oct 9, 2024
Merged

Conversation

youngbeom-shin
Copy link
Member

What this PR does:
replace hex color into dolor tokens
Which issue(s) this PR fixes:

Fixes #

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary.

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

Checklist:

  • I have added unit/e2e tests that prove your fix is effective or that this feature works.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have reviewed my own code and ensured that it follows the project's style guidelines.

Release note:


'success-800': '#085D3A',
'success-900': '#074D31',
'success-950': '#053321',

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty line

hiveer
hiveer previously approved these changes Oct 9, 2024
Copy link
Collaborator

@hiveer hiveer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youngbeom-shin youngbeom-shin requested a review from hiveer October 9, 2024 08:51
Copy link
Collaborator

@hiveer hiveer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiveer hiveer merged commit e5529cd into main Oct 9, 2024
3 checks passed
@hiveer hiveer deleted the csghub__replace-color-design-token branch October 9, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants