-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix add to collections #765
Conversation
MR Evaluation:This feature is still under test, evaluation are given by AI and might be inaccurate. After evaluation, the code changes in the Merge Request get score: 65-76. Analysis for the evaluation score:
TipsCodeReview Commands (invoked as MR or PR comments)
CodeReview Discussion ChatThere are 2 ways to chat with Starship CodeReview:
Note: Be mindful of the bot's finite context window. CodeReview Documentation and Community
About Us:Visit the OpenCSG StarShip website for the Dashboard and detailed information on CodeReview, CodeGen, and other StarShip modules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The TipsCodeReview Commands (invoked as MR or PR comments)
CodeReview Discussion ChatThere are 2 ways to chat with Starship CodeReview:
Note: Be mindful of the bot's finite context window. CodeReview Documentation and Community
|
* Fix add to collections * Use userStore not cookie * onMounted => watch --------- Co-authored-by: minghao.yang <mh.yang@opencsg.com>
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary.
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note:
MR Summary:
The summary is added by @codegpt.
The Merge Request focuses on fixing the "add to collections" functionality. Key updates include:
onMounted
anduseCookies
from Vue, improving the component's initialization and user data handling.userName
prop, replacing it with acurrentUser
ref derived from cookies, to streamline user identification and collection fetching.fetchCollectionsList
function to use the current user's information, ensuring collections are correctly fetched based on the authenticated user.RepoClone.vue
component to align with the changes inAddToCollections.vue
, removing theuserName
prop to support the updated user handling approach.