Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider the case of error response nil #889

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

hiveer
Copy link
Collaborator

@hiveer hiveer commented Jan 6, 2025

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary.

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

Checklist:

  • I have added unit/e2e tests that prove your fix is effective or that this feature works.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have reviewed my own code and ensured that it follows the project's style guidelines.

Release note:


@hiveer hiveer self-assigned this Jan 6, 2025
Copy link
Collaborator

@zhendi zhendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiveer hiveer merged commit f511917 into main Jan 7, 2025
3 checks passed
@hiveer hiveer deleted the csghub__bug-fix-use-fetch-error branch January 7, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants