Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spurious "Your changes will be lost" warning message #1206

Closed
matterhorn103 opened this issue Dec 4, 2022 · 5 comments · Fixed by #1406
Closed

Spurious "Your changes will be lost" warning message #1206

matterhorn103 opened this issue Dec 4, 2022 · 5 comments · Fixed by #1406
Labels
bug

Comments

@matterhorn103
Copy link
Contributor

Avogadro version: (please complete the following information from the About box):

  • Flatpak of version 1.97.0
  • Avogadrolibs: 1.97.0
  • Qt: 5.15.7

Desktop version: (please complete the following information):

  • OS: OpenSUSE Tumbleweed but behaviour on Windows 10 is identical
  • Version 20221201

Describe the bug
If the user has an open molecule that is unsaved and then clicks the "Open..." button, a warning message appears:

Do you want to save the changes to the document?
Your changes will be lost if you don't save them.
Save | Discard | Cancel

And this is simply not true, if Discard is chosen and a file is then opened, the unsaved molecule is still there and the opened file is put into a new "molecule" in the Molecules window.
@ghutchis
Copy link
Member

ghutchis commented Dec 7, 2022

Yeah, there's something happening to the layers that's noted as a change. I haven't been able to find the exact bug.

@ghutchis ghutchis added the bug label May 10, 2023
ghutchis added a commit to ghutchis/avogadrolibs that referenced this issue Oct 25, 2023
@ghutchis
Fix spurious "change layer" bug with the selection tool
a0c5053 
Fix OpenChemistry#1206 - layer is not created by default
Fix OpenChemistry#1192 - layer is not changed, avoiding a crash

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
@ghutchis ghutchis mentioned this issue Oct 25, 2023
Merged
@github-actions
Copy link
Contributor

Here are the build results
Avogadro2.AppImage
macOS.dmg
Win64.exe
Artifacts will only be retained for 90 days.

@github-actions
Copy link
Contributor

Here are the build results
Avogadro2.AppImage
macOS.dmg
Win64.exe
Artifacts will only be retained for 90 days.

@matterhorn103
Copy link
Contributor Author

Can this be reopened? The spurious message still appears.

@ghutchis
Copy link
Member

Please open a new bug report.

@matterhorn103 matterhorn103 mentioned this issue Feb 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix spurious "change layer" bug with the selection tool ghutchis/avogadrolibs
2 participants
@ghutchis @matterhorn103