Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: first item in ordered plugin dialog is empty #1632

Open
matterhorn103 opened this issue Feb 23, 2024 · 7 comments
Open

Regression: first item in ordered plugin dialog is empty #1632

matterhorn103 opened this issue Feb 23, 2024 · 7 comments

Comments

@matterhorn103
Copy link
Contributor

matterhorn103 commented Feb 23, 2024

Avogadro version: (please complete the following information from the About box):

  • Avogadrolibs: 1.99.0
  • Qt: 5.15.2

Desktop version: (please complete the following information):

  • OS: Linux AppImage, Windows, macOS
  • Version: various
  • Compiler: for self-compiled build, clang

Describe the bug
The bug that I described and fixed here seems to be back.

Weirdly, it doesn't occur on my personal build of Avogadro from the latest codebase. However, it does in the 1.99 AppImage, I get the impression it's also happening on Windows, and @JGrantHill also reports it happening on macOS (ARM).

To Reproduce
Steps to reproduce the behavior:

  1. Install the avo_xtb plugin
  2. Open the "Configure..." menu or anything else that has a dialog e.g. Run or Conformers
  3. Observe that first field is always empty, even after entering a path and saving the config, or after adding the path manually to Avogadro/commands/avo_xtb/config.json
@avo-bot
Copy link

avo-bot commented Feb 23, 2024

This issue has been mentioned on Avogadro Discussion. There might be relevant details there:

https://discuss.avogadro.cc/t/regression-first-item-in-ordered-plugin-dialog-is-empty/5320/1

@avo-bot
Copy link

avo-bot commented Oct 7, 2024

This issue has been mentioned on Avogadro Discussion. There might be relevant details there:

https://discuss.avogadro.cc/t/xtb-plugin-installation/6340/15

@matterhorn103
Copy link
Contributor Author

Still bizarrely remains the case that the version of Avogadro that I have compiled myself doesn't have this issue, but all other versions apparently do.

Could this be a bug that was fixed in very recent Qt5 versions? I compiled against 5.15.15, whereas the nightly AppImage is compiled against 5.15.2.

@ghutchis
Copy link
Member

That's certainly possible. Is the qt6 version able to run the plugins? If so, does that fix the bug?

My feeling is that it's probably better to push ahead with migrating to qt6 sooner.

@matterhorn103
Copy link
Contributor Author

Is the qt6 version able to run the plugins?

No, sadly. That's actually the only thing I've been able to spot that doesn't work in my Qt6 build.

@matterhorn103
Copy link
Contributor Author

matterhorn103 commented Oct 19, 2024

QRegularExpression has 38 instances in avogadrolibs, many of them in files related to the plugins, so I'll prioritize porting those over the next week or so, and maybe that will solve everything...

@ghutchis
Copy link
Member

@matterhorn103 - why don't you post something on the forum. Maybe a few others would be willing to help with porting.

IIRC some of that has to do with context highlighting in the input generators, which isn't so crucial. That could be #ifdef for qt5-only for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants