Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please allow Ball and Stick and Cartoons in Rétegek (Layers) to be translatable #950

Closed
1 task done
ovari opened this issue Jun 16, 2022 · 14 comments
Closed
1 task done

Comments

@ovari
Copy link
Contributor

ovari commented Jun 16, 2022

Avogadro version:

Desktop version:

  • OS: Linux Mint 20.3 Cinnamon

Describe the bug
Please allow Layer 1, Ball and Stick and Cartoons in Rétegek (Layers) to be translatable.

To Reproduce
Please see image in the Screenshots section.

Expected behavior
In Rétegek (Layers) the following should show in Hungarian:

  1. Layer 1fixed
  2. Ball and Stick
  3. Cartoons

Screenshots
Layers

Thank you

@ghutchis ghutchis transferred this issue from OpenChemistry/avogadroapp Jun 16, 2022
@github-actions
Copy link
Contributor

Here are the build results
macOS-arm64.dmg
Artifacts will only be retained for 90 days.

@ghutchis
Copy link
Member

Thanks! I think I have solved this, but will need the rest of the translation infrastructure to catch up - might take a few days. I'll keep it open until I can confirm it's fixed.

@github-actions
Copy link
Contributor

Here are the build results
Avogadro2.AppImage
macOS.dmg
Ubuntu-2004.tar.gz
Win64.exe
Artifacts will only be retained for 90 days.

@ovari
Copy link
Contributor Author

ovari commented Jun 18, 2022

I'll keep it open until I can confirm it's fixed.

Can you please re-open this issue as it is not fixed. Thank you

@ghutchis ghutchis reopened this Jun 18, 2022
@ovari
Copy link
Contributor Author

ovari commented Jun 29, 2022

Partially fixed as shown in image below:

kép

Thank you

@ovari ovari changed the title Please allow Layer 1, Ball and Stick and Cartoons in Rétegek (Layers) to be translatable Please allow <s>Layer 1</s>, Ball and Stick and Cartoons in Rétegek (Layers) to be translatable Jun 29, 2022
@ovari ovari changed the title Please allow <s>Layer 1</s>, Ball and Stick and Cartoons in Rétegek (Layers) to be translatable Please allow Ball and Stick and Cartoons in Rétegek (Layers) to be translatable Jun 29, 2022
@ghutchis
Copy link
Member

ghutchis commented Jul 1, 2022

Weird because the upper panel is translated. I'll look into it.

@ghutchis
Copy link
Member

ghutchis commented Jul 2, 2022

I had to hack this, but #992 should fix once the translation files update in a few days.

(Better to have a bit of a hack than untranslated strings, for sure.)

@ovari
Copy link
Contributor Author

ovari commented Jul 5, 2022

It seems that now the items are no longer showing.

kép

@ghutchis
Copy link
Member

ghutchis commented Jul 5, 2022

😞

@ghutchis
Copy link
Member

ghutchis commented Jul 5, 2022

Well, I guess it's at least some sort of progress? I'll check out what's happening. Thanks for your patience.

@ovari
Copy link
Contributor Author

ovari commented Jul 19, 2022

Fixed with recent (~last hour) download. Thank you

kép

@ovari ovari closed this as completed Jul 19, 2022
@ghutchis
Copy link
Member

Thanks for all the hard work. Hopefully we can get the remaining i18n bugs fixed and put out a 1.97 release with 100% translation this week or next.

@ovari
Copy link
Contributor Author

ovari commented Jul 19, 2022

That would be great. Hopefully the File option multiplicity can be easily reduced from 3 to 1.

@ghutchis
Copy link
Member

I think this PR should help with that:
OpenChemistry/avogadroapp#296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants