Remove dependency on embassy-executor#594
Merged
tullom merged 12 commits intoOpenDevicePartnership:v0.2.0from Dec 2, 2025
Merged
Remove dependency on embassy-executor#594tullom merged 12 commits intoOpenDevicePartnership:v0.2.0from
embassy-executor#594tullom merged 12 commits intoOpenDevicePartnership:v0.2.0from
Conversation
tullom
requested review from
RobertZ2011,
asasine,
philgweber,
thdesil and
wmmc88
tullom
added
enhancement
asasine
reviewed
Nov 20, 2025
kurtjd
reviewed
Nov 20, 2025
tullom
force-pushed
the
remove-embassy-executor-deps
branch
from
9bae58c to
f0bdca1
Compare
kurtjd
approved these changes
Nov 22, 2025
Contributor
Author
No, however I think that there are unintended consequences if a task that should not terminate, terminates. It might lead to UB, which is why we should panic instead of silently failing. |
RobertZ2011
approved these changes
Nov 24, 2025
jerrysxie
force-pushed
the
remove-embassy-executor-deps
branch
from
f0bdca1 to
73ce52f
Compare
Contributor
|
@tullom since we will be making quite a few API breaking changes in v0.2.0, let's keep a running list of breaking changes so that we can publish a changelog later when it is merged back into main. |
jerrysxie
approved these changes
Nov 24, 2025
philgweber
reviewed
Dec 1, 2025
philgweber
approved these changes
Dec 1, 2025
seanbrns
approved these changes
Dec 2, 2025
williampMSFT
added a commit
that referenced
this pull request
Dec 16, 2025
#594 moved the responsibility for declaring async tasks from embedded-services to the application layer. To support this, some tasks that needed to be generic over a type (which is not directly supported by embassy) made into macros that emit a function that uses a concrete type. The application layer is required to call that macro and then implement a task that invokes the generated function. However, in the case of the keyboard service, there appears to be a typo causing the name of the type identifier being passed into the macro to not match the name of the type identifier that is actually used in the macro, resulting in a compilation error whenever a user tries to actually invoke the macro. This change fixes the typo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of our services should be able to run agnostic of an async executor. While we use embassy, the ability to use tokio for testing in std environments should be supported.
All tasks that should be spawned in a thread have been moved to each subsystem's respective
tasknamespace, so that users know to spawn all async functions within that namespace.