Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerun from notes #1719

Closed

Conversation

smathermather
Copy link
Contributor

@smathermather smathermather commented Nov 8, 2023

Per #1718, an attempt to document appropriate rerun-from places.

@smathermather
Copy link
Contributor Author

Some of these are known to be correct, some are best guesses. Not all flags are noted, especially those that would require a complete or nearly complete rerun of the toolchain.

@pierotofy
Copy link
Member

pierotofy commented Nov 8, 2023

This seems a bit verbose. In my opinion this belongs to the documentation.

p.s. the missing guide 2nd has a table with all the rerun stages; feel free to double check from there.

But the real issue is: people don't know/remember which stage to restart from if they change an option.

Ideally, ODM would already know which settings were used in the previous run (we currently don't), compare the previous with the current options, and automatically pick the restart point.

E.g.

./run.sh /datasets/brighton

./run.sh /datasets/brighton --orthophoto-resolution 2 --> rerun from orthophoto stage without needing to specify: --rerun from odm_orthophoto. That would remove the need to know the stages.

@smathermather
Copy link
Contributor Author

smathermather commented Nov 8, 2023

I don't agree on verbosity (although suggestions for how to shorten and remain clear quite welcome), and agree wrt docs, but if implemented here it is in the docs and always in the docs, rather than drifting apart from the docs.

Agree on functionality, but that's a different pull request altogether. Happy to make this obsolete with such a pull request in the future (should be easier now that we have json to parse), but not today.

Folks regularly ask for this info. I'd love for it to be in docs and up-to-date with the code by default.

(Edit: I'll edit from that table. My copy happily remained in Zambia with Dr. Samboko. I was too lazy this evening to dig up my digital copy but can review tomorrow or Thursday.)

@pierotofy pierotofy mentioned this pull request Nov 8, 2023
@smathermather smathermather deleted the rerun-from-notes branch March 14, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants