Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PoissonRecon failed with n threads log message #1756

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

andrewharvey
Copy link
Contributor

@andrewharvey andrewharvey commented Apr 18, 2024

The message was reporting failure with n threads and retrying with n // 2, however a few lines up threads was already set to n // 2 representing the next thread count to try.

You'll see currently the log finishing with

[WARNING] PoissonRecon failed with 1 threads, let's retry with 0...

which demonstrates the issues.

The message was reporting failure with n threads and retrying with n // 2, however a few lines up threads was already set to n // 2 representing the next thread count to try.
@pierotofy
Copy link
Member

Nice catch @andrewharvey ! Thanks for the patch. 🙏

@pierotofy pierotofy merged commit 424d9e2 into OpenDroneMap:master Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants