Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make euclidean merge available in contrib directory #1802

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

smathermather
Copy link
Contributor

@smathermather smathermather commented Sep 17, 2024

An attempt to expose the euclidean merge that so helpfully is part of split merge to merge other, similarly formatted elevation models, say one from MERIT Hydro and another from OpenDroneMap.

@smathermather
Copy link
Contributor Author

smathermather commented Sep 17, 2024

There's something I'm doing wrong here, I could use a hint. I'm unclear if it's the format of my inputs tifs or something subtler.

Got it. Had a path issue on output.

docker run -ti --rm -v /home/sillyuser/merging:/input --entrypoint /code/contrib/dem-blend/dem-blend.py dem_blend /input
[INFO]    Computing euclidean distance: /input/merit.euclideand.tif
0...10...20...30...40...50...60...70...80...90...100 - done.
[INFO]    Computing euclidean distance: /input/dsm.euclideand.tif
0...10...20...30...40...50...60...70...80...90...100 - done.
[INFO]    2 valid DEM rasters to merge
[INFO]    Output bounds: 642157.3721 8321070.3609 660157.3721 8331420.3609
[INFO]    Output width: 9000, height: 5175
[INFO]    Adjusted bounds: 642157.3721 8321070.3609 660157.3721 8331420.3609
(base) sillyuser@crankier:~/merging$ ls
dsm.euclideand.tif  dsm.tif  merit.euclideand.tif  merit.tif

@smathermather
Copy link
Contributor Author

Looks like once possible issue with general use is null values are hard coded:
https://github.com/OpenDroneMap/ODM/blob/master/opendm/dem/commands.py#L203C14-L203C19

@smathermather smathermather marked this pull request as ready for review September 18, 2024 00:08
@smathermather
Copy link
Contributor Author

What I haven't looked at is the multiprocessing side of this. I don't even know if the dem merge step supports multiprocessing, so that's a bit of dangling import that needs resolved. Otherwise: ready for review.

@pierotofy
Copy link
Member

👍

@pierotofy pierotofy merged commit 65fad52 into OpenDroneMap:master Sep 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants