Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit Enabling / Disabling Workflows #2715

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Audit Enabling / Disabling Workflows #2715

merged 4 commits into from
Nov 28, 2024

Conversation

elias-ba
Copy link
Contributor

@elias-ba elias-ba commented Nov 26, 2024

Description

This PR introduces a function that allows to write audit logs when a workflow is enabled or disabled. That function is used in the Workflows.save_workflow/2 function as a step in the Ecto.Multi to achieve atomicity.

Closes #2697

Validation steps

  1. Toggle the enable / disable state of a workflow
  2. Save
  3. See the action written in the audit logs

Additional notes for the reviewer

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our Responsible AI Policy

Pre-submission checklist

  • I have performed a self-review of my code.
  • I have implemented and tested all related authorization policies. (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.12%. Comparing base (19bd2bf) to head (39982fd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2715   +/-   ##
=======================================
  Coverage   91.11%   91.12%           
=======================================
  Files         333      333           
  Lines       11794    11803    +9     
=======================================
+ Hits        10746    10755    +9     
  Misses       1048     1048           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stuartc stuartc merged commit d4d52bf into main Nov 28, 2024
8 checks passed
@stuartc stuartc deleted the 2697-audit branch November 28, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Enhance Workflows.save_workflow/1 to Audit Enable/Disable Actions
2 participants