Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend LightningWeb.AuditLive.Index.diff/1 behaviour #2701

Open
rorymckinley opened this issue Nov 21, 2024 · 0 comments · May be fixed by #2702
Open

Extend LightningWeb.AuditLive.Index.diff/1 behaviour #2701

rorymckinley opened this issue Nov 21, 2024 · 0 comments · May be fixed by #2702
Assignees

Comments

@rorymckinley
Copy link
Collaborator

The diff function is responsible for representing the before and after changes of an audit entry in the UI.

As part of auditing the GH connection removal, I need to make some changes to diff as it does not appear to support a use-case where there is before data but no after data.

While looking at the implementation, I noticed that there were some edge cases which I ran into that I thought might affect future work around audits.

The work for this issue will try to smooth out some of the wrinkles while also adding in some new functionality to support auditing the deletion of GH connections.

@rorymckinley rorymckinley self-assigned this Nov 21, 2024
@github-project-automation github-project-automation bot moved this to New Issues in v2 Nov 21, 2024
@rorymckinley rorymckinley linked a pull request Nov 21, 2024 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New Issues
Development

Successfully merging a pull request may close this issue.

1 participant