Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn before closing a form with unsaved changes #780

Open
taylordowns2000 opened this issue Apr 6, 2023 · 7 comments · May be fixed by #1044
Open

Warn before closing a form with unsaved changes #780

taylordowns2000 opened this issue Apr 6, 2023 · 7 comments · May be fixed by #1044
Labels
feature enhancement New feature or request

Comments

@taylordowns2000
Copy link
Member

taylordowns2000 commented Apr 6, 2023

Starting with the job builder because it's the most high-impact, we need an elegant and generic way to detect when a form has unsaved changes (maybe through the validate hook?) then then display a warning before the user closes.

This is particularly important on the job builder since clicking anywhere else on the canvas will close the form. See @josephjclark 's old #280

  • When making changes to a job, a user's changes aren't saved until the "save" button is pressed (this itself is arguably a little bit anachronistic).
  • If the user refreshes the page, navigates away or goes "back" (easily done with a misplaced gesture), all changes will be lost without warning.
  • This is particularly painful when writing job code.

@NickOpenFn
Copy link

Do in the next sprint, requires UI

@NickOpenFn
Copy link

Noting that this is badly spec'd for taking into the sprint

@elias-ba elias-ba linked a pull request Aug 23, 2023 that will close this issue
4 tasks
@elias-ba
Copy link
Contributor

Technically blocked. See this question on the Elixir Forum.

@NickOpenFn
Copy link

Moving into backlog. When planned again will need a spike to look at alternatives.

@taylordowns2000
Copy link
Member Author

taylordowns2000 commented Jun 27, 2024

@stuartc , this also relates to #2007 ?

@taylordowns2000 taylordowns2000 moved this from Icebox to Blocked in v2 Jun 27, 2024
@christad92
Copy link

@midigofrank's work on #2297 should help with this. Modals will not close by clicking outside them.

@midigofrank correct?

@midigofrank
Copy link
Collaborator

@christad92 yes and no. I don't think the modals in the workflow page uses the same component as the one in #2297.
But we can use the same technique.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature enhancement New feature or request
Projects
Status: Blocked
Development

Successfully merging a pull request may close this issue.

5 participants