Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn before closing a form with unsaved changes #1044

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

elias-ba
Copy link
Contributor

Notes for the reviewer

Related issue

Fixes #780

Review checklist

  • I have performed a self-review of my code
  • I have verified that all appropriate authorization policies have been implemented and tested
  • If needed, I have updated the changelog
  • Product has QA'd this feature

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (cddf52f) 85.78% compared to head (18b9ec1) 85.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1044      +/-   ##
==========================================
+ Coverage   85.78%   85.79%   +0.01%     
==========================================
  Files         184      184              
  Lines        5206     5210       +4     
==========================================
+ Hits         4466     4470       +4     
  Misses        740      740              
Files Changed Coverage Δ
lib/lightning_web/live/workflow_live/edit.ex 94.83% <100.00%> (+0.09%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Icebox
Development

Successfully merging this pull request may close these issues.

Warn before closing a form with unsaved changes
1 participant