Add HT40 support to iwn (Centrino Wireless-N) #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxystd
requested changes
Feb 1, 2021
| if (ni->ni_htcaps & IEEE80211_HTCAP_SGI40) | ||
| tx->rflags |= IWN_RFLAG_SGI | IWN_RFLAG_HT40; | ||
| if (ni->ni_htcaps & IEEE80211_HTCAP_CBW20_40) | ||
| tx->rflags |= IWN_RFLAG_HT40; |
There was a problem hiding this comment.
we should not mix capabilities and current mode, 40mhz mode didn't means that it support SGI40. should change like this
if (ni->ni_chw == 40) {
tx->rflags |= IWN_RFLAG_HT40;
if (ieee80211_node_supports_ht_sgi40(ni)) {
tx->rflags |= IWN_RFLAG_SGI;
}
}
There was a problem hiding this comment.
Thanks for the suggestion. I've updated the code to take current mode as consideration.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 802.11n 40MHz to Centrino Wireless-N cards in
iwndriver.The iwn_update_chw is left as placeholder, and appear not being called.
The proper rxon 40mhz channel flags need to set during association. If the flags only set at run, it appear doesn't work. This may be different than the ctxt in iwm/iwx.
All others are strait forward.
I've tested on Wireless-N 6205 card.